Sometimes it helps to have someone else look at code you have written. If you are asked to review someone's patch, please put some effort into it. This checklist is a starting point to help you think of some things to look out for. It is not a comprehensive list of all things required to perform a sufficient code review.

Some things to do before signing off on a patch:

If you find a problem with the code that you're reviewing or have a question about it, please do not hesitate to point it out to the original author. They're asking you to look at their code in hopes you will uncover problems before they get committed.

Of course, this checklist is also useful to go through before submitting a patch for review. :-)

en/development/code_review_ideas.txt · Last modified: 2008/07/24 11:19 by amoore
Except where otherwise noted, content on this wiki is licensed under the following license:CC Attribution-Noncommercial-Share Alike 3.0 Unported
Recent changes RSS feed Donate Powered by PHP Valid XHTML 1.0 Valid CSS Driven by DokuWiki