Sometimes it helps to have someone else look at code you have written. If you are asked to review someone's patch, please put some effort into it. This checklist is a starting point to help you think of some things to look out for. It is not a comprehensive list of all things required to perform a sufficient code review.

Some things to do before signing off on a patch:

• apply the patch to the appropriate branch to verify that it applies cleanly
• verify that all updated functions and methods have updated POD if necessary
• verify that all new functions and methods have sufficient POD
• If there are database changes, run kohastructure.sql to make sure it is syntactically correct (this is also caught by running the full DB-dependent test suite, i.e., 'cd t; make test')
• if there are database changes, run updatedatabase.pl through the web interface to make sure it succeeds
• watch the error logs (e.g., Apache) while you test the patch - that may turn up problems or left-over debug warns
• … please add your own suggestions here.

If you find a problem with the code that you're reviewing or have a question about it, please do not hesitate to point it out to the original author. They're asking you to look at their code in hopes you will uncover problems before they get committed.

Of course, this checklist is also useful to go through before submitting a patch for review.